zsnes: amend fortify3 patch and fix initialization #265039
Conversation
I was too eager fixing out-of-bounds access and did not notice that loop increment is `+= 4` instead of `+= 1`. The loop condition was fine as is.
ofborg
bot
added
10.rebuild-darwin: 0
|
And I was too eager to merge. Runs fine, and LGTM. |
That's a great question! I don't think there is a strong consensus on that. Or even on what the maintainer's responsibilities exactly are. My personal thoughts: I think the default maintainer's timeout of 1-2 weeks is very reasonable whether it's ZHF time or not. Gentoo has a similar guideline for non-maintainer commits. Over time you might notice that some people don't review PRs for packages they maintain at all and you might want to expedite the changes for their packages. Ideally such defunct maintainer entries should be removed by maintainers themselves. In practice it's rarely done. |
|
Thanks for your input. I've been thinking that a discussion about this on Discourse could be quite healthy. Different classes of contribution do call for different time frames to respond. Module additions, version bumps, major package changes, or small amends/fixups such as this pull are examples of changes that call for different review time frames. ZHF, staging(-next), and whether the fix is blocking other things are also a major modifiers to consider. Some may think any wait time may kill momentum, and an other problem I also see with such wait times is that a committer may review a PR and say "LGTM" before the time window has passed, then forget to come back later and merge it, seeing as we do not have a reminder bot configured. I just had to talk myself into thinking fixups are fine to merge swiftly |
I was too eager fixing out-of-bounds access and did not notice that loop increment is
+= 4instead of+= 1. The loop condition was fine as is.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)